Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart account tests #13

Merged
merged 4 commits into from
Apr 9, 2024
Merged

smart account tests #13

merged 4 commits into from
Apr 9, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 9, 2024

PR-Codex overview

This PR focuses on enhancing the SmartAccount functionality by adding new methods for admin operations and improving transaction handling.

Detailed summary

  • Added methods to add and remove admins in SmartAccount
  • Improved transaction input validation in SmartAccount
  • Added methods to get personal account and sign data in SmartAccount
  • Enhanced testing coverage for SmartAccount functionality

The following files were skipped due to too many changes: Thirdweb.Tests/Thirdweb.SmartAccount.Tests.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (f6d1c49) to head (27caf62).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   87.55%   93.70%   +6.15%     
==========================================
  Files          15       15              
  Lines         948     1001      +53     
  Branches       87       88       +1     
==========================================
+ Hits          830      938     +108     
+ Misses        104       50      -54     
+ Partials       14       13       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 97dc0ed into main Apr 9, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/t-smart-account branch April 9, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants